[Mesa-dev] [PATCH 00/18] improvements for GL_KHR_debug support

[Brian Paul]

On 04/25/2014 04:41 AM, Chia-I Wu wrote:
> Hi,
>
> This series cleans up GL_KHR_debug support, fixes message control for some
> corner cases, and makes one enhancement: cheap
> glPushDebugGroup/glPopDebugGroup for command stream annotation.
>
> Patch 1-12 refactor the code.  There should be no functional difference.
> These patches are also part of the series I sent the other day for threaded
> glCompileShader.
>
> Patch 13 makes an interface change to hide struct gl_debug_state from the rest
> of the driver.  I need this for threaded glCompileShader support.  But I think
> this is a good idea anyhow because, unlike other context states,
> gl_debug_state is created on demand.  This prevents others from having to do
> an if-check.
>
> Patch 14-16 refactor more of the code.  No functional difference is expected
> either.
>
> Patch 17 makes debug group pushing copy-on-write.  This makes the operation
> very cheap in a common scenario.
>
> Patch 18 simplifies the debug namespace code a lot and fixes a few corner
> cases.
>
> Please review.

Looks great.  Nice clean-ups and I'm really happy to see the memory use 
getting reined in.

I just had a couple tiny comments.

For the series,
Reviewed-by: Brian Paul <brianp at vmware.com>

-Brian