[Mesa-dev] [PATCH 11/16] glx/apple: explicitly assign struct components for glx_*_vtable

[Kristian Høgsberg]

On Sun, Mar 16, 2014 at 6:48 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> ... to improve readability of code. Set applegl_screen_vtable as a static const.
>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>

Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

> ---
>  src/glx/applegl_glx.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/src/glx/applegl_glx.c b/src/glx/applegl_glx.c
> index a67416e..4e2d5d0 100644
> --- a/src/glx/applegl_glx.c
> +++ b/src/glx/applegl_glx.c
> @@ -109,15 +109,15 @@ applegl_get_proc_address(const char *symbol)
>  }
>
>  static const struct glx_context_vtable applegl_context_vtable = {
> -   applegl_destroy_context,
> -   applegl_bind_context,
> -   applegl_unbind_context,
> -   applegl_wait_gl,
> -   applegl_wait_x,
> -   DRI_glXUseXFont,
> -   NULL, /* bind_tex_image, */
> -   NULL, /* release_tex_image, */
> -   applegl_get_proc_address,
> +   .destroy             = applegl_destroy_context,
> +   .bind                = applegl_bind_context,
> +   .unbind              = applegl_unbind_context,
> +   .wait_gl             = applegl_wait_gl,
> +   .wait_x              = applegl_wait_x,
> +   .use_x_font          = DRI_glXUseXFont,
> +   .bind_tex_image      = NULL,
> +   .release_tex_image   = NULL,
> +   .get_proc_address    = applegl_get_proc_address,
>  };
>
>  struct glx_context *
> @@ -164,8 +164,11 @@ applegl_create_context(struct glx_screen *psc,
>     return gc;
>  }
>
> -struct glx_screen_vtable applegl_screen_vtable = {
> -   applegl_create_context
> +static const struct glx_screen_vtable applegl_screen_vtable = {
> +   .create_context         = applegl_create_context,
> +   .create_context_attribs = NULL,
> +   .query_renderer_integer = NULL,
> +   .query_renderer_string  = NULL,
>  };
>
>  _X_HIDDEN struct glx_screen *
> --
> 1.9.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev