[Mesa-dev] [PATCH 00/19] Implement GL_ARB_multi_bind v2

[Fredrik Höglund]

On Tuesday 22 April 2014, Brian Paul wrote:
> On 04/21/2014 03:57 PM, Fredrik Höglund wrote:
> > So here is version two of the ARB_multi_bind series.
> >
> > This incorporates feedback from Brian, Matt and Francisco, and also
> > fixes an issue I happened to notice myself.  It occurred to me that
> > the BindTexture driver hook doesn't have a parameter for the texture
> > index, and that drivers might want to know which texture was changed.
> > It turns out that the only driver that implements the hook is nouveau,
> > and the index is the only thing it cares about.  So there is now a new
> > patch that adds an index parameter and adjusts the driver accordingly.
> >
> > I have also updated my branch at:
> >
> > git://people.freedesktop.org/~fredrik/mesa arb-multi-bind
> >
> 
> The series looks good to me.  Just some minor nit-picks.  When we print 
> a GLsizei we need to use %d, not %u, since GLsizei is a signed type.  I 
> think I saw about 10 instances of that.
> 
> For the series:  Reviewed-by: Brian Paul <brianp at vmware.com>
> 
> BTW, do we have piglit tests for this extension?

I have a set of piglit tests I haven't posted yet.  There are no draw tests,
so they're not as complete as I would like.  But they test error conditions
and setting and quering state.
 
> > Note that the BindBuffers patches have still not been reviewed.
> 
> That's a different patch series?  I don't remember it.

No, by BindBuffers I meant BindBuffersBase/Range and BindVertexBuffers,
so it's the same series.

Fredrik