[Mesa-dev] [PATCH] i965: Actually emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> For platforms using hardware contexts (currently Gen6+), we failed to
> emit PIPELINE_SELECT and 3DSTATE_VF_STATISTICS, instead emitting MI_NOOP
> for both.
>
> During one of the context initialization reordering patches, we
> accidentally moved brw_init_state before we set brw->CMD_PIPELINE_SELECT
> and brw->CMD_VF_STATISTICS.  So, when brw_init_state uploaded initial
> GPU state (brw_init_state -> brw_upload_initial_gpu_state ->
> brw_upload_invariant_state), these would be 0 (MI_NOOP).
>
> Storing the commands in the context is not worthwhile.  We have many
> generation checks in our state upload code, and for platforms with
> hardware contexts, this only gets called once per GL context anyway.
> The cost is negligable, and it's easy to botch context creation
> ordering.
>
> This may fix hangs on Gen6+ when using the media pipeline.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140429/a7ad12f0/attachment.sig>