[Mesa-dev] [PATCH v2 2/2] egl: Add EGL_CHROMIUM_sync_control extension.

[Chad Versace]

This patch looks good to me.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

On Thu, Apr 24, 2014 at 04:32:08PM -0700, Sarah Sharp wrote:
> Chromium defined a new GL extension (that isn't registered with Khronos).
> We need to add an EGL extension for it, so we can migrate ChromeOS on
> Intel systems to use EGL instead of GLX.
> 
> http://git.chromium.org/gitweb/?p=chromium/src/third_party/khronos.git;a=commitdiff;h=27cbfdab35c601f70aa150581ad1448d0401f447
> 
> The EGL_CHROMIUM_sync_control extension is similar to the GLX extension
> OML_sync_control, but only defines one function,
> eglGetSyncValuesCHROMIUM, which is equivalent to glXGetSyncValuesOML.
> 
> http://www.opengl.org/registry/specs/OML/glx_sync_control.txt
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp at linux.intel.com>
> Cc: Chad Versace <chad.versace at linux.intel.com>
> Cc: Jamey Sharp <jamey at minilop.net>
> Cc: Ian Romanick <idr at freedesktop.org>
> Cc: Stéphane Marchesin <stephane.marchesin at gmail.com>
> ---
> 
> v2:
>  - Clear up confusion around extension vs functions.  The new EGL
>    extension name is CHROMIUM_sync_control and the new function name is
>    eglGetSyncValuesCHROMIUM.
>  - Remove all instances of #ifdef EGL_CHROMIUM_sync_control, but leave
>    the #define in include/EGL/eglext.h.
>  - Extensions are sorted by group, then alphabetically.  Make sure to
>    respect that when adding the EGL_CHROMIUM_sync_control extension.
>  - Set EGL error codes where appropriate.  Make sure
>    dri2_x11_get_sync_values and eglGetSyncValuesCHROMIUM set an EGL
>    error code they fail.
>  - Use the newly imported Chromium header, rather than putting the
>    extension in eglext.h (which will be overwritten as new versions are
>    imported from Khronos).
> 
>  src/egl/drivers/dri2/egl_dri2.c           | 10 ++++++++++
>  src/egl/drivers/dri2/egl_dri2.h           |  4 ++++
>  src/egl/drivers/dri2/egl_dri2_fallbacks.h |  8 ++++++++
>  src/egl/drivers/dri2/platform_android.c   |  1 +
>  src/egl/drivers/dri2/platform_drm.c       |  1 +
>  src/egl/drivers/dri2/platform_wayland.c   |  1 +
>  src/egl/drivers/dri2/platform_x11.c       | 29 +++++++++++++++++++++++++++++
>  src/egl/main/eglapi.c                     | 23 +++++++++++++++++++++++
>  src/egl/main/eglapi.h                     |  3 +++
>  src/egl/main/egldisplay.h                 |  2 ++
>  src/egl/main/eglmisc.c                    |  2 ++
>  11 files changed, 84 insertions(+)