[Mesa-dev] [PATCH] nvc0: treat non-linear 2DRect textures the same as 2D

Ilia Mirkin imirkin at alum.mit.edu
Tue Apr 29 21:19:15 PDT 2014


This fixes textureGather(2DRect) piglit tests, and does not appear to
have any adverse effects.

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
---

Not sure why the sampler would care whether it's 2D or 2DRect in the first
place. But I think the only difference between a non-linear RECT texture and a
2D one are the normalized coordinates, which are their own flag.

 src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c b/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c
index 765cd2d..1b11bd0 100644
--- a/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c
+++ b/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c
@@ -173,7 +173,7 @@ nvc0_create_texture_view(struct pipe_context *pipe,
       tic[2] |= NV50_TIC_2_TARGET_2D;
       break;
    case PIPE_TEXTURE_RECT:
-      tic[2] |= NV50_TIC_2_TARGET_RECT;
+      tic[2] |= NV50_TIC_2_TARGET_2D;
       break;
    case PIPE_TEXTURE_3D:
       tic[2] |= NV50_TIC_2_TARGET_3D;
-- 
1.8.3.2



More information about the mesa-dev mailing list