[Mesa-dev] [PATCH 6/9] i965/fs: Port untyped surface read support to Broadwell.

Eric Anholt eric at anholt.net
Wed Apr 30 13:33:20 PDT 2014


Kenneth Graunke <kenneth at whitecape.org> writes:

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77221
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

> diff --git a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp
> index 856a23e..dae4026 100644
> --- a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp
> +++ b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp
> @@ -821,6 +821,34 @@ gen8_fs_generator::generate_unpack_half_2x16_split(fs_inst *inst,
>  }
>  
>  void
> +gen8_fs_generator::generate_untyped_surface_read(fs_inst *ir,
> +                                                 struct brw_reg dst,
> +                                                 struct brw_reg surf_index)
> +{
> +   assert(surf_index.file == BRW_IMMEDIATE_VALUE &&
> +          surf_index.type == BRW_REGISTER_TYPE_UD);
> +
> +   const unsigned num_channels = 1;

unused value?

> +
> +   unsigned msg_control = 0xe | /* Enable only the R channel */
> +     ((dispatch_width == 16 ? 1 : 2) << 4); /* Slot Group: SIMD8 or SIMD16 */

In the specs I'm looking at, this is called "simd mode", not "slot
group"  (if it was slot group like for aops, I'd be concerned since a
simd16 op needs to use all 16 slots)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140430/b5392907/attachment.sig>


More information about the mesa-dev mailing list