[Mesa-dev] [PATCH] winsys/radeon: fix nop packet padding for hawaii

[Michel Dänzer]

On 01.08.2014 22:09, Andreas Boll wrote:
> The initial firmware for hawaii does not support type3 nop packet.
> Detect the new hawaii firmware with query RADEON_INFO_ACCEL_WORKING2.
> If the returned value is 2, then the new firmware is used.
> 
> This patch uses type2 for the old firmware and type3 for the new firmware.
> 
> It fixes the cases when the old firmware is used and the user wants to
> manually enable acceleration.
> The two possible scenarios are:
>  - the kernel has no support for the new firmware.
>  - the kernel has support for the new firmware but only the old firmware
>    is available.
> 
> Cc: mesa-stable at lists.freedesktop.org
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Jérôme Glisse <jglisse at redhat.com>
> Signed-off-by: Andreas Boll <andreas.boll.dev at gmail.com>
> ---
> 
> Unfortunately I can't test this patch myself since I don't own a hawaii card.
> So I'd need someone to test this patch on kernel >= 3.16-rc7.
> This patch would bring us one step further for hawaii acceleration on kernel 1.16.

It's not enough though, e.g. the kernel itself was also using the wrong
NOP packets.

I think it would be better if the radeon winsys refused to initialize on
Hawaii if RADEON_INFO_ACCEL_WORKING2 doesn't return 2, just like the
Xorg driver.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer