[Mesa-dev] [PATCH] targets/dri: resolve the scons build

Roland Scheidegger sroland at vmware.com
Fri Aug 1 21:36:55 PDT 2014


Am 02.08.2014 05:49, schrieb Emil Velikov:
> With earlier commit we've conditionally enabled/added the kms_dri target
> for automake builds. Unfortunately the we forgot to add the appropriate
> define in the scons build, resulting in a broken library due to the
> undefined symbol 'kms_swrast_create_screen'.
> 
> Reported-by: Roland Scheidegger <sroland at vmware.com>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
> 
> Thanks for spotting this Roland.
> 
> This patch fixes the issue here, can you confirm that it resolves it on 
> your end as well please ?
> 
> /me puts the brown bag and steps aside from the builds for a moment.
> 
> -Emil
> 
>  src/gallium/targets/dri/SConscript | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/targets/dri/SConscript b/src/gallium/targets/dri/SConscript
> index 8cb90b3..7c567c3 100644
> --- a/src/gallium/targets/dri/SConscript
> +++ b/src/gallium/targets/dri/SConscript
> @@ -29,6 +29,7 @@ env.Append(CPPDEFINES = [
>      'GALLIUM_VMWGFX',
>      'GALLIUM_SOFTPIPE',
>      'DRI_TARGET',
> +    'HAVE_LIBDRM',
>  ])
>  
>  env.Prepend(LIBS = [
> 

This indeed fixes things. Thanks!

Tested-by: Roland Scheidegger <sroland at vmware.com>



More information about the mesa-dev mailing list