[Mesa-dev] [PATCH] i965: Emit a performance warning on conditional rendering.

[Chris Forbes]

Since we were just discussing this in IRC,

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

On Mon, Aug 4, 2014 at 6:54 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> We have a CPU-side implementation of conditional rendering; it really
> should be done on the GPU.  It's not necessarily that hard, but nobody
> has gotten to fixing it yet.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_draw.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
> index 4dae7d3..412c360 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> @@ -539,6 +539,11 @@ void brw_draw_prims( struct gl_context *ctx,
>
>     assert(unused_tfb_object == NULL);
>
> +   if (ctx->Query.CondRenderQuery) {
> +      perf_debug("Conditional rendering is implemented in software and may "
> +                 "stall.  This should be fixed in the driver.\n");
> +   }
> +
>     if (!_mesa_check_conditional_render(ctx))
>        return;
>
> --
> 2.0.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev