[Mesa-dev] [PATCH v2 00/13] Rework the texture upload code

[Brian Paul]

On 08/02/2014 02:11 PM, Jason Ekstrand wrote:
> This is a direct rework of the patch series starting here:
>
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/archives/mesa-dev/2014-July/063483.html&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=HUNGyfTjzYlF3%2Btw%2FjiWURrNNVka9h4tzUBJn2NWblc%3D%0A&s=84e48a860d7664f8bb436d19d243010ab827e21e93a0bbe3bfdeee11eb89854a
>
> I've tried to address all of the direct comments given on those patches.
> This version is much better documented and even a little faster.
>
> Jason Ekstrand (13):
>    mesa: Add a format description CSV file
>    mesa: Add python to parse the formats CSV file
>    mesa/formats: Autogenerate the format_info structure from a CSV file
>    mesa/formats: Remove IndexBits
>    mesa/formats: Add layout and swizzle information
>    meas: Gather some common format conversion functions into a single
>      file
>    mesa/imports: Add a _mesa_half_is_negative helper function
>    mesa/format_utils: Add a general format conversion function
>    mesa/format_utils: Add a function to convert a mesa_format to an array
>      format
>    main/texstore: Split texture storage into three functions
>    mesa/texstore: Use _mesa_swizzle_and_convert when possible
>    mesa/texstore: Add a generic float/normalized rgba texture upload path
>    mesa/texstore: Add a generic rgba integer texture upload path
>
>   src/mesa/Makefile.am             |   10 +
>   src/mesa/Makefile.sources        |    1 +
>   src/mesa/SConscript              |    1 +
>   src/mesa/main/.gitignore         |    1 +
>   src/mesa/main/format_info.py     |  192 +++
>   src/mesa/main/format_pack.c      |  102 +-
>   src/mesa/main/format_parser.py   |  521 +++++++
>   src/mesa/main/format_unpack.c    |   69 +-
>   src/mesa/main/format_unpack.h    |    3 -
>   src/mesa/main/format_utils.c     | 1005 ++++++++++++
>   src/mesa/main/format_utils.h     |   77 +
>   src/mesa/main/formats.c          | 1786 +--------------------
>   src/mesa/main/formats.csv        |  282 ++++
>   src/mesa/main/formats.h          |   29 +
>   src/mesa/main/imports.h          |    5 +
>   src/mesa/main/texcompress_etc.c  |   20 +-
>   src/mesa/main/texcompress_s3tc.c |   26 +-
>   src/mesa/main/texstore.c         | 3197 +++++++-------------------------------
>   18 files changed, 2834 insertions(+), 4493 deletions(-)
>   create mode 100644 src/mesa/main/format_info.py
>   create mode 100755 src/mesa/main/format_parser.py
>   create mode 100644 src/mesa/main/format_utils.c
>   create mode 100644 src/mesa/main/format_utils.h
>   create mode 100644 src/mesa/main/formats.csv
>

I did a quick re-review and things look pretty good.  Just some minor 
nit-picks on a few patches.

Reviewed-by: Brian Paul <brianp at vmware.com>