[Mesa-dev] [PATCH] targets/dri: link with mesautil

[Emil Velikov]

On 05/08/14 01:32, Roland Scheidegger wrote:
> Am 05.08.2014 01:52, schrieb Emil Velikov:
>> On 05/08/14 00:36, sroland at vmware.com wrote:
>>> From: Roland Scheidegger <sroland at vmware.com>
>>>
>>> Build system so I've no idea what I'm doing but this looks similar to other
>>> build fixes...
>>> ---
>>>  src/gallium/targets/dri/SConscript | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/src/gallium/targets/dri/SConscript b/src/gallium/targets/dri/SConscript
>>> index 7c567c3..f7d793b 100644
>>> --- a/src/gallium/targets/dri/SConscript
>>> +++ b/src/gallium/targets/dri/SConscript
>>> @@ -7,6 +7,7 @@ if env['suncc']:
>>>      Return()
>>>  
>>>  env.Append(CPPPATH = [
>>> +    '#/src',
>> Please drop this. We're talking about linking issues not compilation.
> Sure. I told you I didn't know what I am doing :-).
> 
>>
>>>      '#/src/loader',
>>>      '#/src/mapi',
>>>      '#/src/mesa',
>>> @@ -33,6 +34,7 @@ env.Append(CPPDEFINES = [
>>>  ])
>>>  
>>>  env.Prepend(LIBS = [
>>> +    mesautil,
>> And feel free to move this one above the mesa lib.
>>>      st_dri,
>>>      svgadrm,
>>>      svga,
>>>
> 
> Well mesa is below in this same env.Prepend. I thought that meant it
> would be linked first. Isn't that correct?
> 
I'm not entirely sure how strict the link order is with scons, esp. in this
case. IMHO it would be preferable to have 'mesautil' and 'mesa' side by side,
but that's only to ease future work :)

-Emil
> Roland
> 
> 
>> With those fixed the patch is
>> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>>
>