[Mesa-dev] [PATCH] glsl_to_tgsi: Fix typo shader_program -> shader

Brian Paul brianp at vmware.com
Tue Aug 5 06:31:16 PDT 2014


On 08/05/2014 12:34 AM, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> This was a regression introduced by commit
> f4b0ab7afd83c811329211eae8167c9bf238870c ('st/mesa: fix incorrect size
> of UBO declarations') which caused an assertion failure while compiling
> shaders of e.g. UE4 demos.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81834
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> ---
>   src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index a165d6a..c5e2eb5 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -5113,8 +5113,7 @@ st_translate_program(
>         unsigned num_ubos = program->shader->NumUniformBlocks;
>
>         for (i = 0; i < num_ubos; i++) {
> -         unsigned size =
> -            program->shader_program->UniformBlocks[i].UniformBufferSize;
> +         unsigned size = program->shader->UniformBlocks[i].UniformBufferSize;
>            unsigned num_const_vecs = (size + 15) / 16;
>            unsigned first, last;
>            assert(num_const_vecs > 0);
>

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list