[Mesa-dev] [PATCH 0/2] clover: add clCompileProgram

[EdB]

On Tuesday, August 05, 2014 03:38:48 PM Francisco Jerez wrote:
> EdB <edb+mesa at sigluy.net> writes:
> > Hello
> > 
> > I'm done with the clCompile part of OpenCL 1.2.
> > 
> > As you can see I use char* data to transfert data from core to llvm.
> > 
> > At first I was thinking of using std class but we need to be binary safe
> > when data are transfert beetween c++98/c++11 compiled code.
> > 
> > Then I try to use compat class, but it add unexpected behavior.
> 
> It would be good to know what's causing that unexpected behavior.
> 
> > It's looks like they are acting like std, but they don't.
> 
> Yes, compat::vector implements the bare minimum required for the
> compiler interface to work, it was never my intention to write a
> complete replacement of std::vector.
> 
> > For exemple vector.reserve is actually making the vector size grown,
> > not like std::vector. Also std::string.c_str is always null terminated.
> > compat::string is not.
> 
> It would be nice to fix those if they're a problem for you.
Ok, I'll do that. I'll sent a separate series to fix compat and then resend 
this one
> 
> > At the end I decide to use const char* as it also avoid some memory copy,
> > but I can rewrite the patch if it's needed.
> > And I think compat need to be fixed.
> > 
> > EdB (2):
> >   clover: std::pair is not c++98/c++11 safe
> >   clover: add clCompileProgram
> >  
> >  src/gallium/state_trackers/clover/api/dispatch.cpp |  2 +-
> >  src/gallium/state_trackers/clover/api/program.cpp  | 41
> >  ++++++++++++++++++++-- .../state_trackers/clover/core/compiler.hpp      
> >   | 11 +++---
> >  src/gallium/state_trackers/clover/core/program.cpp | 14 ++++++--
> >  src/gallium/state_trackers/clover/core/program.hpp |  5 ++-
> >  .../state_trackers/clover/llvm/invocation.cpp      | 33 +++++++++++++----
> >  src/gallium/state_trackers/clover/util/compat.hpp  |  6 ++++
> >  7 files changed, 95 insertions(+), 17 deletions(-)
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev