[Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

[Michel Dänzer]

On 06.08.2014 03:08, Jason Ekstrand wrote:
> Module: Mesa
> Branch: master
> Commit: 850fb0d1dca616179d3239a7b7bd94fe1979604c
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=850fb0d1dca616179d3239a7b7bd94fe1979604c
> 
> Author: Jason Ekstrand <jason.ekstrand at intel.com>
> Date:   Thu Jul 10 23:59:42 2014 -0700
> 
> mesa/formats: Add layout and swizzle information
> 
> v2: Move the MESA_FORMAT_SWIZZLE enum to the top of the file
> 
> Signed-off-by: Jason Ekstrand <jason.ekstrand at intel.com>
> Reviewed-by: Brian Paul <brianp at vmware.com>

As of this commit, ~20 depth/stencil related piglit tests have regressed with the radeonsi driver compared to before your changes. See below for an example failure of the draw-pixels test.

That test is already broken with the previous commits, each of them with slightly different failure symptoms.


Mesa 10.3.0-devel implementation error: Unexpected inFormat GL_STENCIL_INDEX
Please report at https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa
Mesa 10.3.0-devel implementation error: Unexpected inFormat 0xffffffff
Please report at https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa
Mesa 10.3.0-devel implementation error: Unexpected inFormat 0xffffffff
Please report at https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa
Probe stencil at (0, 0)
  Expected: 50
  Observed: 100
Probe color at (0,0)
  Expected: 1.000000 0.000000 0.000000 1.000000
  Observed: 0.000000 0.000000 0.000000 1.000000
Probe color at (0,0)
  Expected: 0.000000 0.396078 0.000000 1.000000
  Observed: 0.000000 0.384314 0.000000 1.000000
Probe color at (0,0)
  Expected: 0.000000 0.000000 0.396078 1.000000
  Observed: 0.000000 0.000000 0.384314 1.000000
Probe color at (0,0)
  Expected: 0.396078 0.427451 0.000000 1.000000
  Observed: 0.384314 0.415686 0.000000 1.000000
Probe color at (0,0)
  Expected: 0.396078 0.427451 0.458824 1.000000
  Observed: 0.384314 0.415686 0.447059 1.000000
Probe color at (0,0)
  Expected: 0.458824 0.427451 0.396078 1.000000
  Observed: 0.447059 0.415686 0.384314 1.000000
Probe color at (0,0)
  Expected: 0.458824 0.427451 0.396078 0.490196
  Observed: 0.447059 0.415686 0.384314 0.478431
Probe color at (0,0)
  Expected: 0.396078 0.396078 0.396078 0.427451
  Observed: 0.384314 0.384314 0.384314 0.415686
Mesa 10.3.0-devel implementation error: Unexpected inFormat 0xffffffff
Please report at https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa
Mesa 10.3.0-devel implementation error: Unexpected inFormat 0xffffffff
Please report at https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa
draw-pixels: ../../../src/mesa/main/pack.c:4669: _mesa_unpack_color_span_uint: Assertion `srcFormat == 0x1903 || srcFormat == 0x1904 || srcFormat == 0x1905 || srcFormat == 0x1906 || srcFormat == 0x1909 || srcFormat == 0x190A || srcFormat == 0x8049 || srcFormat == 0x8227 || srcFormat == 0x1907 || srcFormat == 0x80E0 || srcFormat == 0x1908 || srcFormat == 0x80E1 || srcFormat == 0x8000 || srcFormat == 0x8D94 || srcFormat == 0x8D95 || srcFormat == 0x8D96 || srcFormat == 0x8D97 || srcFormat == 0x8228 || srcFormat == 0x8D98 || srcFormat == 0x8D99 || srcFormat == 0x8D9A || srcFormat == 0x8D9B || srcFormat == 0x8D9C || srcFormat == 0x8D9D' failed.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer