[Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

[Marek Olšák]

On Wed, Aug 6, 2014 at 5:53 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>       pc->MaxAddressRegs     = pc->MaxNativeAddressRegs     =
>          _min(screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_MAX_ADDRS),
>               MAX_PROGRAM_ADDRESS_REGS);
>
> Not really sure what that's referring to... ARB_vp/fp or something?

Yes, ARB_vp needs 1, ARB_fp doesn't support indirect addresing (expects 0).

>
> Anyways, this is definitely a bit of a violation of that. OTOH, so is
> the indirect UBO indexing and indirect GS input access (assuming
> that's allowed), since those would use ADDR[1] and every driver
> (except nv30) returns 1, and sometimes 0 -- including
> nv50/nvc0/r600/radeonsi.
>
> So... dunno what the proper way to proceed is. Fix drivers to claim
> higher numbers? Continue the tradition of ignoring it and relying on
> the fact that GPU's that don't support it also won't support the
> features that cause it to get used?

You don't have to worry about that for now. We can clean it up later.

Marek