[Mesa-dev] [PATCH] gallium: remove PIPE_SHADER_CAP_MAX_ADDRS

[Marek Olšák]

On Thu, Aug 7, 2014 at 12:32 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Wed, Aug 6, 2014 at 6:06 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> This limit is fixed in Mesa core and cannot be changed.
>> It only affects ARB_vertex_program and ARB_fragment_program.
>>
>> The minimum value for ARB_vertex_program is 1 according to the spec.
>> The maximum value for ARB_vertex_program is limited to 1 by Mesa core.
>
> Just want to point out that i915 always returned 0 for that. Did it
> not support ARB_vp?

i915 does vertex processing on the CPU. The i915g driver returns
limits from Draw for the vertex shader (draw_get_shader_param).

>
>>
>> The value should be zero for ARB_fragment_program, because it doesn't
>> support ARL.
>>
>> Finally, drivers shouldn't mess with these values arbitrarily.
>
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> May want to let this one sit for a bit too, or at least to get
> reviewed by someone with more of a clue than myself.
>
>> ---
>>
>> Sidenote: Does anybody use predicates in TGSI?
>
> I've never even seen them before, I guess glsl->tgsi never creates
> them? I wonder if these things are useful for d3d-type st's though...
> (does d3d9 have predicates?)
>
> nv50/nvc0 do have predicate support at the instruction level though.
> Not sure if the tgsi -> nv50 ir translator supports that though.

Nothing is using predicates in the tree and the same for st/nine.

Marek