[Mesa-dev] [PATCH] i965/vec4: Remove unused emit_bool_comparison method.

[Anuj Phogat]

On Thu, Aug 7, 2014 at 10:35 AM, Matt Turner <mattst88 at gmail.com> wrote:
> Apparently unused since it was added in commit af3c9803.
> ---
>  src/mesa/drivers/dri/i965/brw_vec4.h           |  1 -
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 14 --------------
>  2 files changed, 15 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h
> index 3d0df77..950b592 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.h
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.h
> @@ -486,7 +486,6 @@ public:
>                      src_reg src0, src_reg src1, src_reg one);
>
>     void emit_bool_to_cond_code(ir_rvalue *ir, enum brw_predicate *predicate);
> -   void emit_bool_comparison(unsigned int op, dst_reg dst, src_reg src0, src_reg src1);
>     void emit_if_gen6(ir_if *ir);
>
>     void emit_minmax(enum brw_conditional_mod conditionalmod, dst_reg dst,
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index 23d1dae..c46325a 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -1174,20 +1174,6 @@ vec4_visitor::try_emit_b2f_of_compare(ir_expression *ir)
>  }
>
>  void
> -vec4_visitor::emit_bool_comparison(unsigned int op,
> -                                dst_reg dst, src_reg src0, src_reg src1)
> -{
> -   /* original gen4 does destination conversion before comparison. */
> -   if (brw->gen < 5)
> -      dst.type = src0.type;
> -
> -   emit(CMP(dst, src0, src1, brw_conditional_for_comparison(op)));
> -
> -   dst.type = BRW_REGISTER_TYPE_D;
> -   emit(AND(dst, src_reg(dst), src_reg(0x1)));
> -}
> -
> -void
>  vec4_visitor::emit_minmax(enum brw_conditional_mod conditionalmod, dst_reg dst,
>                            src_reg src0, src_reg src1)
>  {
> --
> 1.8.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>