[Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

[Jason Ekstrand]

Michel,

On Thu, Aug 7, 2014 at 12:04 AM, Michel Dänzer <michel at daenzer.net> wrote:

> On 07.08.2014 02:02, Jason Ekstrand wrote:
> > Michael,
>
> Close, but no cigar. :)
>

I'm sorry about that.  I must have read too quickly. :-/


>
> > Could you please point me at the failing tests.
>
> spec/!OpenGL 1.1/depthstencil-default_fb-drawpixels-FLOAT-and-USHORT
> spec/!OpenGL 1.1/draw-pixels
> spec/!OpenGL 1.1/stencil-drawpixels
> spec/!OpenGL 1.4/copy-pixels
>
> spec/ARB_depth_buffer_float/fbo-depthstencil-GL_DEPTH32F_STENCIL8-drawpixels-FLOAT-and-USHORT
> spec/ARB_depth_buffer_float/fbo-stencil-GL_DEPTH32F_STENCIL8-drawpixels
> spec/EXT_framebuffer_object/fbo-stencil-GL_STENCIL_INDEX1-drawpixels
> spec/EXT_framebuffer_object/fbo-stencil-GL_STENCIL_INDEX16-drawpixels
> spec/EXT_framebuffer_object/fbo-stencil-GL_STENCIL_INDEX14-drawpixels
> spec/EXT_framebuffer_object/fbo-stencil-GL_STENCIL_INDEX8-drawpixels
>
> spec/EXT_packed_depth_stencil/fbo-depthstencil-GL_DEPTH24_STENCIL8-drawpixels-FLOAT-and-USHORT
> spec/EXT_packed_depth_stencil/fbo-stencil-GL_DEPTH24_STENCIL8-drawpixels
>
> (The total number of regressions is around 20 because some of these are
> run for several numbers of samples)
>
>
> > I don't have a radeon, but I can run with llvmpipe or dri swrast and
> > try to find the bug that way.
>
> At least the draw-pixels test indeed regressed with llvmpipe as well.
>

The draw pixels regression on llvmpipe is different.  The changes I made to
texture upload included a subtle change in the way we handle signed input
data.  In older GL versions there were two formulas, one which mapped
[-128, 127] to [-1, 1] and one which mapped [-127, 127] to [-1, 1].  The
former formula was used when uploading a non-snorm texture from signed
integer data or when doing operations such as DrawPixels and ReadPixels.
In GL 4.3, this first formula is going away and we will only have the later
formula.  (The later formula has the advantage of mapping 0 to 0.)  If we
think it's needed, I can add code to the swizzle_and_convert function to be
able to handle the legacy formula in those cases where older GL versions
say that it's needed.


>
> Would it be possible for you to verify that there are no piglit gpu.py
> regressions with llvmpipe before pushing changes like these?
>

Yeah, I'm going to get my personal testing infrastructure set up to make
that easier and hopefully I can do so in the future.

--Jason Ekstrand
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140807/f9ec424e/attachment.html>