[Mesa-dev] Mesa (master): mesa/formats: Add layout and swizzle information

Jason Ekstrand jason at jlekstrand.net
Thu Aug 7 11:38:54 PDT 2014


On Wed, Aug 6, 2014 at 11:09 AM, Marek Olšák <maraeo at gmail.com> wrote:

> FYI, it seems to be DrawPixels(GL_STENCIL_INDEX) that is broken. We
> actually use S8 texturing for DrawPixels and some of the functions you
> changed probably don't support S8 anymore.
>

Marek,
Would you mind being a bit more specific?  I don't think I changed any of
the upload code for stencil formats.  Also, I still don't see what any of
this has to do with data in formats.c.
--Jason


>
> Marek
>
> On Wed, Aug 6, 2014 at 7:37 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > Michael,
> > With the two patches I just sent to the list, the generated format_info
> > structure is now binary-identical to the original structure commited to
> git
> > with the following two exceptions: The string name parameter for
> > MESA_FORMAT_R9G9B9E5_FLOAT was updated from "MESA_FORMAT_RGB9_E5" to
> > "MESA_FORMAT_R9G9B9E5_FLOAT".  The LATC formats now report 8 bits of
> > precision instead of 4;  This makes the LATC formats match the RGTC
> formats
> > which use exactly the same compression just interpreted differently.
> >
> > I'm really confused about where the bug is coming from.  That said, I'm
> > going to run some llvmpipe tests to see if I can reproduce.
> > --Jason Ekstrand
> >
> >
> > On Wed, Aug 6, 2014 at 10:02 AM, Jason Ekstrand <jason at jlekstrand.net>
> > wrote:
> >>
> >> Michael,
> >> Could you please point me at the failing tests.  I don't have a radeon,
> >> but I can run with llvmpipe or dri swrast and try to find the bug that
> way.
> >> --Jason Ekstrand
> >>
> >>
> >> On Wed, Aug 6, 2014 at 2:36 AM, Michel Dänzer <michel at daenzer.net>
> wrote:
> >>>
> >>> On 06.08.2014 18:28, Michel Dänzer wrote:
> >>> > On 06.08.2014 03:08, Jason Ekstrand wrote:
> >>> >> Module: Mesa
> >>> >> Branch: master
> >>> >> Commit: 850fb0d1dca616179d3239a7b7bd94fe1979604c
> >>> >> URL:
> >>> >>
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=850fb0d1dca616179d3239a7b7bd94fe1979604c
> >>> >>
> >>> >> Author: Jason Ekstrand <jason.ekstrand at intel.com>
> >>> >> Date:   Thu Jul 10 23:59:42 2014 -0700
> >>> >>
> >>> >> mesa/formats: Add layout and swizzle information
> >>> >>
> >>> >> v2: Move the MESA_FORMAT_SWIZZLE enum to the top of the file
> >>> >>
> >>> >> Signed-off-by: Jason Ekstrand <jason.ekstrand at intel.com>
> >>> >> Reviewed-by: Brian Paul <brianp at vmware.com>
> >>> >
> >>> > As of this commit, ~20 depth/stencil related piglit tests have
> >>> > regressed with the radeonsi driver compared to before your changes.
> >>> > See below for an example failure of the draw-pixels test.
> >>> >
> >>> > That test is already broken with the previous commits, each of them
> >>> > with slightly different failure symptoms.
> >>>
> >>> I meant to write: 'That test is already broken with the three previous
> >>> commits, [...]'
> >>>
> >>>
> >>> --
> >>> Earthling Michel Dänzer            |
> http://www.amd.com
> >>> Libre software enthusiast          |                Mesa and X
> developer
> >>
> >>
> >
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140807/a96999df/attachment.html>


More information about the mesa-dev mailing list