[Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

[Roland Scheidegger]

Ah right. That's why it didn't matter then :-)

Roland

Am 08.08.2014 02:30, schrieb Marek Olšák:
> Hi Roland,
> 
> This code isn't used by llvmpipe, because it returns
> PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0.
> 
> Marek
> 
> On Fri, Aug 8, 2014 at 1:33 AM, Roland Scheidegger <sroland at vmware.com> wrote:
>> Looks good to me too. I guess on llvmpipe we got lucky because
>> row_stride and layer_stride were equal so the math worked out the same
>> in the end :-).
>>
>> Reviewed-by: Roland Scheidegger <sroland at vmware.com>
>>
>> Am 08.08.2014 01:18, schrieb Ilia Mirkin:
>>> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>>
>>> Makes sense and also fixes the new piglit on nvc0.
>>>
>>> On Thu, Aug 7, 2014 at 6:49 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>>> From: Marek Olšák <marek.olsak at amd.com>
>>>>
>>>> This fixes piglit spec/EXT_texture_array/render-1darray.
>>>>
>>>> Cc: mesa-stable at lists.freedesktop.org
>>>> ---
>>>>  src/mesa/state_tracker/st_cb_texture.c | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c
>>>> index 5a5efcb..969a05f 100644
>>>> --- a/src/mesa/state_tracker/st_cb_texture.c
>>>> +++ b/src/mesa/state_tracker/st_cb_texture.c
>>>> @@ -776,6 +776,8 @@ st_TexSubImage(struct gl_context *ctx, GLuint dims,
>>>>
>>>>     /* From now on, we need the gallium representation of dimensions. */
>>>>     if (gl_target == GL_TEXTURE_1D_ARRAY) {
>>>> +      zoffset = yoffset;
>>>> +      yoffset = 0;
>>>>        depth = height;
>>>>        height = 1;
>>>>     }
>>>> --
>>>> 1.9.1
>>>>
>>>> _______________________________________________
>>>> mesa-dev mailing list
>>>> mesa-dev at lists.freedesktop.org
>>>> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=F4msKE2WxRzA%2BwN%2B25muztFm5TSPwE8HKJfWfR2NgfY%3D%0A&m=0IfN%2BKGuZIxMEIcZVCPLUkq%2Fgny20Dg122U%2FExRyjrU%3D%0A&s=e1b3851bd515ebb354fe18243071a635c086e73d24547e2a7ad853f7735b5eb6
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=F4msKE2WxRzA%2BwN%2B25muztFm5TSPwE8HKJfWfR2NgfY%3D%0A&m=0IfN%2BKGuZIxMEIcZVCPLUkq%2Fgny20Dg122U%2FExRyjrU%3D%0A&s=e1b3851bd515ebb354fe18243071a635c086e73d24547e2a7ad853f7735b5eb6
>>>
>>