[Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

[Neil Roberts]

Thanks for the review. I've pushed the Mesa patch and I'll have a look
at adding more formats to the Piglit test.

Regards,
- Neil

Kenneth Graunke <kenneth at whitecape.org> writes:

> On Tuesday, July 01, 2014 04:04:56 PM Neil Roberts wrote:
>> > FWIW, I relaxed the format restrictions in
>> > brw_blorp_copytexsubimage, so it can handle general format
>> > conversions as well (i.e. RGBA_FLOAT16 -> RGBA8888_UNORM). There's
>> > no reason we couldn't do that for BlitFramebuffer as well, I just
>> > forgot to do it (and then we decided to make it a newbie task, and
>> > then the newbie didn't do said task, and...oops.)
>> 
>> Ok, I think that is a good idea. Here is a patch to do it. I'm also
>> sending a test to the piglit mailing list that tries blitting between
>> different formats.
>> 
>> Regards,
>> - Neil
>
> Oh, sorry I missed this!  This looks good to me, and it'll be good to have this for 10.3...
>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>