[Mesa-dev] [PATCH] winsys/radeon: fix hawaii accel_working2 comment

Alex Deucher alexdeucher at gmail.com
Wed Aug 13 13:02:51 PDT 2014


On Wed, Aug 13, 2014 at 3:30 PM, Andreas Boll
<andreas.boll.dev at gmail.com> wrote:
> accel_working2 returns 3 if the new firmware is used.
>
> The comment wasn't updated in v3 of commit:
> 36771dc winsys/radeon: fix nop packet padding for hawaii
>
> Signed-off-by: Andreas Boll <andreas.boll.dev at gmail.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c
> index dd109af..ecf8957 100644
> --- a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c
> +++ b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c
> @@ -447,7 +447,7 @@ static void radeon_drm_cs_flush(struct radeon_winsys_cs *rcs,
>          /* pad DMA ring to 8 DWs to meet CP fetch alignment requirements
>           * r6xx, requires at least 4 dw alignment to avoid a hw bug.
>           * hawaii with old firmware needs type2 nop packet.
> -         * accel_working2 with value 2 indicates the new firmware.
> +         * accel_working2 with value 3 indicates the new firmware.
>           */
>          if (cs->ws->info.chip_class <= SI ||
>              (cs->ws->info.family == CHIP_HAWAII &&
> --
> 2.0.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list