[Mesa-dev] [PATCH 02/12] i965: Add an option to not generate the SIMD8 fragment shader

[Matt Turner]

On Mon, Aug 11, 2014 at 10:35 PM, Kristian Høgsberg <hoegsberg at gmail.com> wrote:
> On Mon, Aug 11, 2014 at 08:08:33PM -0700, Ben Widawsky wrote:
>> On Mon, Aug 11, 2014 at 05:29:32PM -0700, Kristian Høgsberg wrote:
>> >     const unsigned *assembly = NULL;
>> >     if (brw->gen >= 8) {
>> >        gen8_fs_generator g(brw, mem_ctx, key, prog_data, prog, fp, v.do_dual_src);
>> > -      assembly = g.generate_assembly(&v.instructions, simd16_instructions,
>> > +      assembly = g.generate_assembly(simd8_instructions, simd16_instructions,
>> >                                       final_assembly_size);
>> >     } else {
>> >        fs_generator g(brw, mem_ctx, key, prog_data, prog, fp, v.do_dual_src,
>> >                       v.runtime_check_aads_emit, INTEL_DEBUG & DEBUG_WM);
>> > -      assembly = g.generate_assembly(&v.instructions, simd16_instructions,
>> > +      assembly = g.generate_assembly(simd8_instructions, simd16_instructions,
>> >                                       final_assembly_size);
>> >     }
>>
>> Suppose you could combine the two.
>
> I don't think so? g is a different type in the two branches.

Moot point now. There's only one generator now.