[Mesa-dev] [PATCH 3/3] mesa: fix compressed_subtexture_error_check() return value

Matt Turner mattst88 at gmail.com
Fri Aug 15 16:30:30 PDT 2014


On Fri, Aug 15, 2014 at 4:04 PM, Brian Paul <brianp at vmware.com> wrote:
> The function should return GLboolean, not GLenum.
> If we detect invalid compressed pixel storage parameters, we should
> return GL_TRUE, not GL_FALSE so that the function is no-op'd.
> An update to the piglit s3tc-errors test will check this.

All three, with a typo fixed in #2 are

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list