[Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

[Francisco Jerez]

EdB <edb+mesa at sigluy.net> writes:

> On Saturday, August 16, 2014 04:37:08 PM Francisco Jerez wrote:
>> EdB <edb+mesa at sigluy.net> writes:
>> > program build should failed if there is created kernel attached to program
>> > 
>> > piglit error:
>> > "Trigger CL_INVALID_OPERATION if there are kernel objects attached to
>> > program">
>> >[...]
>> 
>> How about doing it as follows?
> I used a counter related  to clRetain and clRelease because I was concerned 
> that internally life of core object is not linked to api object.
> ie a clKernel could have released (one clCreate, one clRealease) but clover 
> may still using it and prevent a new build.
> To be fair, I didn't found such case at that moment.

That shouldn't happen, there are no other clover objects keeping
internal references to externally visible kernel objects, and I don't
see how such a thing could ever be useful.  Let's not worry about it.

Does my solution look OK to you?  Does it solve the piglit error in your
setup?

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140816/1319f7dd/attachment.sig>