[Mesa-dev] [PATCH v2 1/8] mesa: add ARB_conditional_render_inverted flags

[Ilia Mirkin]

On Sun, Aug 17, 2014 at 5:15 PM, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
> ---
>  src/mesa/main/condrender.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c
> index 0ad1e5c2..65bdaaf 100644
> --- a/src/mesa/main/condrender.c
> +++ b/src/mesa/main/condrender.c
> @@ -77,6 +77,10 @@ _mesa_BeginConditionalRender(GLuint queryId, GLenum mode)
>     case GL_QUERY_NO_WAIT:
>     case GL_QUERY_BY_REGION_WAIT:
>     case GL_QUERY_BY_REGION_NO_WAIT:
> +   case GL_QUERY_WAIT_INVERTED:
> +   case GL_QUERY_NO_WAIT_INVERTED:
> +   case GL_QUERY_BY_REGION_WAIT_INVERTED:
> +   case GL_QUERY_BY_REGION_NO_WAIT_INVERTED:

These should only be allowed if the extension is present. You can
check for it with ctx->Extensions.ARB_..... . You can be clever about
it by doing like

case GL_QUERY_NO_WAIT:
...
  break;
case GL_QUERY_WAIT_INVERTED:
...
  if (ctx->Extensions.ARB_conditional_render_inverted)
    break;
  /* fallthrough */

>        /* OK */
>        break;
>     default:
> --
> 1.8.4.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev