[Mesa-dev] [PATCH 1/7] build: Let install-lib-links.mk handle .la files in subdirectories.

[Emil Velikov]

On 15/08/14 18:47, Matt Turner wrote:
> The next patches are going to combine some of the mapi subdirectories'
> Makefiles into a single Makefile, giving better build parallelism.
> 
Hi Matt,

I must admit that while I like this patch, I'm not at all a fan of the rest of
the series. But I won't object too strongly against the idea.

IMHO the src/mapi makefiles are messy enough as is. I was even dreaming that
one day we'll be able to build a separate glapi_util (MAPI_MODE_BRIDGE) and
cleanup some of the nasty preprocessor hacks that we have laying around.

This patch is
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

-Emil

> lib_LTLIBRARIES will be set to something like
> 
>    lib_LTLIBRARIES = shared-glapi/libglapi.la es2api/libGLESv2.la
> 
> and the current code in install-lib-links.mk simply prepends .libs/ and
> replaces the .la in order to create the filenames that it needs to ln/cp
> into the LIBDIR. This doesn't work when the .la file is actually in a
> subdirectory.
> 
> This patch fixes this and puts .libs/ in the right place.
> ---
>  install-lib-links.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/install-lib-links.mk b/install-lib-links.mk
> index 09fb86a..5ea73853 100644
> --- a/install-lib-links.mk
> +++ b/install-lib-links.mk
> @@ -7,7 +7,7 @@ all-local : .libs/install-mesa-links
>  
>  .libs/install-mesa-links : $(lib_LTLIBRARIES)
>  	$(AM_V_GEN)$(MKDIR_P) $(top_builddir)/$(LIB_DIR);	\
> -	for f in $(lib_LTLIBRARIES:%.la=.libs/%.$(LIB_EXT)*); do \
> +	for f in $(join $(addsuffix .libs/,$(dir $(lib_LTLIBRARIES))),$(notdir $(lib_LTLIBRARIES:%.la=%.$(LIB_EXT)*))); do \
>  		if test -h .libs/$$f; then			\
>  			cp -d $$f $(top_builddir)/$(LIB_DIR);	\
>  		else						\
>