[Mesa-dev] [PATCH 7/7] i965: Enable instruction compaction on Gen8+.

Kenneth Graunke kenneth at whitecape.org
Mon Aug 18 14:46:54 PDT 2014


On Monday, August 18, 2014 11:19:53 AM Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_eu_compact.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c
> index 727fef5..280d7f7 100644
> --- a/src/mesa/drivers/dri/i965/brw_eu_compact.c
> +++ b/src/mesa/drivers/dri/i965/brw_eu_compact.c
> @@ -1101,7 +1101,7 @@ brw_compact_instructions(struct brw_compile *p, int start_offset,
>      */
>     int old_ip[(p->next_insn_offset - start_offset) / 8];
>  
> -   if (brw->gen < 6 || brw->gen >= 8)
> +   if (brw->gen < 6 || brw->gen > 8)
>        return;
>  
>     int src_offset;
> 

I see no reason why this wouldn't work on Skylake, so I'd just go ahead and do:

if (brw->gen < 6)
   return;

With that change, this is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140818/03b2996e/attachment.sig>


More information about the mesa-dev mailing list