[Mesa-dev] [Bug 82814] glDrawBuffers(0, NULL) segfaults in _mesa_drawbuffers

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=82814

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
FWIW I'm fairly sure that it's actually commit
39b40ad144f5f587e505b45048e33a03641ba857
Author: Brian Paul <brianp at vmware.com>
Date:   Fri Aug 8 15:01:50 2014 -0600

    mesa: fix assertion in _mesa_drawbuffers()

    Fixes failed assertion when _mesa_update_draw_buffers() was called
    with GL_DRAW_BUFFER == GL_FRONT_AND_BACK.  The piglit gl30basic hit
    this.

    Cc: "10.2" <mesa-stable at lists.freedesktop.org>

    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

It changed a if (n == 1) into a if (_mesa_bitcount(...) > 1) without any regard
for n, which might be 0. Should probably be

if (n > 0 && ...) or if (n == 1 && ...). Not entirely sure what the logic is
there though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140819/522e1f31/attachment.html>