[Mesa-dev] [PATCH] glcpp: Don't use alternation in the lookahead for empty pragmas.

[Carl Worth]

Kenneth Graunke <kenneth at whitecape.org> writes:
> Erm.  Shouldn't there be a star here? ^^^

Yikes! I don't know which is more embarrassing. The regression that I
committed that showed I didn't take enough care in running piglit, or
this patch which I submitted to fix it which showed I took even less
care in compiling!

> I can't imagine this compiles...or worse, it does, and continues the comment to the */ in the rule below...
>
>> +<HASH>pragma{HSPACE}*/[\r\n] {
>>  	BEGIN INITIAL;
>>  }

That would have been really bad. It looks like the extended comment
could have formed a legal rule.

Fortunately, the patch as sent didn't compile at all. I had actually
compiled this patch earlier and run piglit. I must have introduced the
bug after that, but before sending the patch off.

> With that fixed, and piglit tested, this would get my Reviewed-by.

Thanks. I fixed this, added your Reviewed-by and a CC to stable, and
pushed this out.

-Carl

PS. Oddly, in a complete run of piglit, I saw that piglit's
17000-consecutive-chars-identifier test was fixed by my patch, but that
the 16385-consecutive-chars.frag test was passing before the patch, (but
that's the test that was originally cited in the bugzilla report).

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140822/c59ca035/attachment.sig>