[Mesa-dev] [PATCH] r600/compute: Don't leak compute pool item_list/unallocated_list

Michel Dänzer michel at daenzer.net
Sun Aug 24 23:37:39 PDT 2014


On 22.08.2014 04:37, Aaron Watry wrote:
> v2: Change to C-style comments and fix indentation
>
> Signed-off-by: Aaron Watry <awatry at gmail.com>
> ---
>   src/gallium/drivers/r600/compute_memory_pool.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c
> index 9324b84..82de9cd 100644
> --- a/src/gallium/drivers/r600/compute_memory_pool.c
> +++ b/src/gallium/drivers/r600/compute_memory_pool.c
> @@ -95,6 +95,11 @@ void compute_memory_pool_delete(struct compute_memory_pool* pool)
>   		pool->screen->b.b.resource_destroy((struct pipe_screen *)
>   			pool->screen, (struct pipe_resource *)pool->bo);
>   	}
> +	/* In theory, all of the items were freed in compute_memory_free.
> +	   Just delete the list heads */

We generally use this format for multi-line comments in our driver code:

	/* First line
	 * [...]
	 * Last line
	 */


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer


More information about the mesa-dev mailing list