[Mesa-dev] [PATCH 6/8] i965: Convert brw state dirty bits to 64-bits

[Jordan Justen]

On Wed, Aug 27, 2014 at 5:41 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Wednesday, August 27, 2014 05:10:36 PM Jordan Justen wrote:
>> r-b with these changes?
>>
>> By the way, chrisf pointed out on irc that we should extend
>> ctx->NewDriverState to 64-bit as well. I'll look into that, but I
>> don't think it needs to block this change. Although, I'd be willing to
>> pull that in here as well if anyone prefers it.
>>
>> -Jordan
>
> If you're going to add BRW_NEW_* bits beyond (1 << 31), then you need to expand ctx->NewDriverState and all of the values in struct gl_driver_flags to be GLbitfield64/uint64_t as well.  We may want to widen the bitfields in the Gallium state tracker to match.
>

Ok. Will do. I looked at NewDriverState, and it didn't look like
changing it would be that tough.

-Jordan

> Failing to do so creates an awkward situation where the DriverFlags mechanism can only use half of the available dirty bits, so we'd have to carefully order bits to avoid truncation problems.  I don't like that at all.
>
> Moving to a 64-bit value makes sense.  But, we need to do both at the same time.  Ideally, I would prefer to see that done first, outside of the rest of your series.