[Mesa-dev] [PATCH 1/4] i965/disasm: Disassemble Z/NZ conditional modifiers as .z/.nz.

[Kenneth Graunke]

On Monday, August 25, 2014 06:41:54 PM Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_disasm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c
> index 424b214..65c6f23 100644
> --- a/src/mesa/drivers/dri/i965/brw_disasm.c
> +++ b/src/mesa/drivers/dri/i965/brw_disasm.c
> @@ -137,8 +137,8 @@ is_logic_instruction(unsigned opcode)
>  
>  const char *const conditional_modifier[16] = {
>     [BRW_CONDITIONAL_NONE] = "",
> -   [BRW_CONDITIONAL_Z]    = ".e",
> -   [BRW_CONDITIONAL_NZ]   = ".ne",
> +   [BRW_CONDITIONAL_Z]    = ".z",
> +   [BRW_CONDITIONAL_NZ]   = ".nz",
>     [BRW_CONDITIONAL_G]    = ".g",
>     [BRW_CONDITIONAL_GE]   = ".ge",
>     [BRW_CONDITIONAL_L]    = ".l",

Both are used in the docs, so it's kind of a toss-up.  I'm fine with this, though, and the rest of the series looks great.

Rather embarassing that we were disassembling PopCount as JumpCount :(

All 4 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140828/2811aa71/attachment.sig>