[Mesa-dev] [PATCH] mesa/st: don't advertise NV_vdpau_interop if it doesn't work.

[Ilia Mirkin]

On Fri, Aug 29, 2014 at 5:59 AM, Christian König
<deathsimple at vodafone.de> wrote:
> From: Christian König <christian.koenig at amd.com>
>
> As long as we don't have a workaround for field based

frame-based... field is the one that's supported.

> decoding in VDPAu we should not advertise NV_vdpau_interop.

VDPAU

>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/mesa/state_tracker/st_extensions.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
> index 9db648c..951c9bf 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -621,7 +621,6 @@ void st_init_extensions(struct pipe_screen *screen,
>     extensions->NV_fog_distance = GL_TRUE;
>     extensions->NV_texture_env_combine4 = GL_TRUE;
>     extensions->NV_texture_rectangle = GL_TRUE;
> -   extensions->NV_vdpau_interop = GL_TRUE;
>
>     extensions->OES_EGL_image = GL_TRUE;
>     extensions->OES_EGL_image_external = GL_TRUE;
> @@ -884,4 +883,10 @@ void st_init_extensions(struct pipe_screen *screen,
>                                     PIPE_BIND_SAMPLER_VIEW)) {
>        extensions->ARB_ES3_compatibility = GL_TRUE;
>     }
> +
> +   if (screen->get_video_param(screen, PIPE_VIDEO_PROFILE_UNKNOWN,

Only a handful of drivers set ->get_video_param. Should check for it
being non-null before invoking it...

> +                               PIPE_VIDEO_ENTRYPOINT_BITSTREAM,
> +                               PIPE_VIDEO_CAP_SUPPORTS_INTERLACED)) {
> +      extensions->NV_vdpau_interop = GL_TRUE;
> +   }
>  }
> --
> 1.9.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev