[Mesa-dev] [Bug 76188] EGL_EXT_image_dma_buf_import fd ownership is incorrect

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76188

Chad Versace <chad.versace at linux.intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #10 from Chad Versace <chad.versace at linux.intel.com> ---
(In reply to comment #9)
> (In reply to comment #7)
> > I do see risk in not cherry-picking the fix. If an app uses this extension
> > with unfixed Mesa 10.2, then that app will leak file descriptors.
> 
> Hmm, isn't it the vice versa though?

Pekka, you're right. I spoke backwards.

> If an app is written to work on unfixed Mesa (the app is broken), it works
> on both unfixed and fixed Mesa, but leaks fds on fixed Mesa, because nothing
> will close the fds given to Mesa.
> 
> If an app is written to work on fixed Mesa (the app is correct), it will not
> work on unfixed Mesa, because unfixed Mesa will close the fds behind the
> app's back. (Assuming the app actually needs to store and use the fds again.)

So regardless of our decision, to backport or not to backport, there will be
bugs. I think the right decision in this case is to prefer supporting apps
written to the correct behavior. So let's backport.

There is another reason to backport: There likely have never existed apps that
relied on the old behavior. During the Khronos discussion where we decided to
"fix" the extension, the consensus was that there were no known in-production
apps that used the extension. Therefore we believed it was safe to "fix" the
extension to follow more traditional Linux fd ownership rules. No existent apps
=> no real compatibility break. Anyway, we predicted that the yet-to-appear
client would might assume traditional fd ownership rules even if we decided to
not fix the extension.

> So, concretely, do I have to send a copy of the patch to mesa-stable@ or
> something, or is it already taken care of?
> Any tag lines to add to the patch?

Just send a copy to mesa-stable at . If you're unsure about the protocol, ask Emil
(xexaxo on #dri-devel).

Everyone following along... does backporting sound sensible to you too? Am I
alone in that opinion?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140830/1f0b37f5/attachment.html>