[Mesa-dev] [PATCH] i965: Make validate_reg tables constant

Matt Turner mattst88 at gmail.com
Mon Dec 1 10:23:31 PST 2014


On Mon, Dec 1, 2014 at 4:59 AM, Juha-Pekka Heikkila
<juhapekka.heikkila at gmail.com> wrote:
> Declare local tables constant. Also added extra '32' at end of
> "width_for_reg" to be future proof, cvt function which give
> indexes to access here could already give index to reach place
> number five now containing '32'.

I don't see any evidence of 32 being a valid width. We don't have a
macro for it in brw_defines.h. Damien's tool [1] also says 32 isn't
valid.

[1] http://damien.lespiau.name/intel/gen_regions.html

With that removed (or justified),

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list