[Mesa-dev] [PATCH 2/5] i965: Drop use of GL types in program keys.

[Matt Turner]

On Mon, Dec 1, 2014 at 12:00 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Monday, December 01, 2014 10:46:30 AM Matt Turner wrote:
>> On Mon, Dec 1, 2014 at 2:00 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> > This is really far removed from the API; we should just use C types.
>> >
>> > Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
>>
>> Can we fix the type of the gen6_gather_wa field while we're at it? We
>> can mark the gen6_gather_sampler_wa as PACKED to keep the 1-byte size.
>
> What type would you suggest?  It's a bitfield of width 3 (WA_SIGN, WA_8BIT,
> and WA_16BIT).
>
> We could convert it from uint8_t[32] to a 96-bit bitfield...

I think it's just a s/uint8_t/enum gen6_gather_sampler_wa/ on this
hunk, isn't it?

   /**
    * For Sandybridge, which shader w/a we need for gather quirks.
    */
   uint8_t gen6_gather_wa[MAX_SAMPLERS];

Unless I've misunderstood something?