[Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

[Jan Vesely]

On Tue, 2014-12-02 at 11:33 -0500, Tom Stellard wrote:
> On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote:
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> > 
> > moreover, the condition is never true now that clover appends dim info
> > 
> >  src/gallium/drivers/r600/evergreen_compute.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c
> > index 90fdd79..41dc93e 100644
> > --- a/src/gallium/drivers/r600/evergreen_compute.c
> > +++ b/src/gallium/drivers/r600/evergreen_compute.c
> > @@ -295,10 +295,6 @@ void evergreen_compute_upload_input(
> >  	struct pipe_box box;
> >  	struct pipe_transfer *transfer = NULL;
> >  
> > -	if (shader->input_size == 0) {
> > -		return;
> > -	}
> > -
> 
> We shouldn't rely on clover specific behavior, because in theory there
> could be other state trackers.

right, I should probably drop that comment from commit message.
Other than that, is there a reason to skip uploading driver arguments if
there are no state tracker ones?

jan

> 
> -Tom
> 
> >  	if (!shader->kernel_param) {
> >  		/* Add space for the grid dimensions */
> >  		shader->kernel_param = (struct r600_resource *)
> > -- 
> > 1.9.3
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141202/00b67fb0/attachment.sig>