[Mesa-dev] [PATCH v2 15/23] configure: require python mako module

[Emil Velikov]

Hi Iago,

Shouldn't this patch come before 13 ? Currently we impose the new
dependency and a couple of commits later we check/document it.

On 01/12/14 11:04, Iago Toral Quiroga wrote:
> From: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> 
> It is now a hard dependency because of the autogeneration of
> format pack and unpack functions.
> 
> Update the documentation to reflect this change.
> 
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> ---
>  configure.ac                      |  2 ++
>  docs/install.html                 |  6 ++++-
>  m4/ax_check_python_mako_module.m4 | 56 +++++++++++++++++++++++++++++++++++++++
>  src/mesa/main/python_mako.py      | 17 ++++++++++++
>  4 files changed, 80 insertions(+), 1 deletion(-)
>  create mode 100644 m4/ax_check_python_mako_module.m4
>  create mode 100644 src/mesa/main/python_mako.py
> 
[...]
> diff --git a/m4/ax_check_python_mako_module.m4 b/m4/ax_check_python_mako_module.m4
> new file mode 100644
> index 0000000..5a66a80
> --- /dev/null
> +++ b/m4/ax_check_python_mako_module.m4
[...]
> +dnl macro that checks for mako module in python
> +AC_DEFUN([AC_CHECK_PYTHON_MAKO_MODULE],
> +[AC_MSG_CHECKING(for module mako in python)
> +    python $srcdir/src/mesa/main/python_mako.py $1
> +    if test $? -ne 0 ; then
> +    AC_MSG_ERROR(mako $1 or later is required.)
> +    fi
> +])
I'm not an m4 wizard, but seems like this will ignore PYTHON2 variable.
Thus Arch and others (were python is a symlink to python3) will end up
with some headaches.
Please drop the src/mesa/main/python_mako.py file and inline it in the
macro. Don't think I've seen an m4 that uses external files.

Thanks
Emil