[Mesa-dev] [PATCH] egl/dri2: Log a warning if no platforms are enabled.

[Matt Turner]

On Wed, Dec 3, 2014 at 11:31 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
> On Wed, Dec 03, 2014 at 11:27:55PM -0800, Ben Widawsky wrote:
>> On Wed, Dec 03, 2014 at 04:47:18PM -0800, Matt Turner wrote:
>> > ---
>> > The number of times I've wondered why piglit/gbm wasn't working...
>> >
>> >  src/egl/drivers/dri2/egl_dri2.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
>> > index d795a2f..2a6811c 100644
>> > --- a/src/egl/drivers/dri2/egl_dri2.c
>> > +++ b/src/egl/drivers/dri2/egl_dri2.c
>> > @@ -659,6 +659,7 @@ dri2_initialize(_EGLDriver *drv, _EGLDisplay *disp)
>> >  #endif
>> >
>> >     default:
>> > +      _eglLog(_EGL_WARNING, "No EGL platform enabled.");
>> >        return EGL_FALSE;
>> >     }
>> >  }
>>
>> Would it be out of line to request a sample in the commit message?
>
> I should say... obviously I know what the error message says, but I don't think
> I ever hit this case, so I am kind of curious how it crops up.

Forgetting to compile with --with-egl-platforms=... leads to
dri2_initialize() being an empty stub. If you take a look at the
function, it's pretty clear, but the symptoms aren't very indicative
of the problem.