[Mesa-dev] [PATCH v3 03/12] i965: Set shader name for generator from call site

Ben Widawsky ben at bwidawsk.net
Fri Dec 5 13:41:41 PST 2014


On Fri, Dec 05, 2014 at 01:36:52PM -0800, Matt Turner wrote:
> On Fri, Dec 5, 2014 at 1:34 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
> > I do wonder the original motivation for the debug_flag member. Seems totally
> > superfluous.
> 
> Because brw_fs_generator is used by the fs and by blorp, and you want
> different debug flags for them.

Beforehand though we had the program type, so you could just as easily read the
debug flag in at that time. I suppose what's there now might look a bit nicer if
you had tons of different consumers of the fs_generator.

Thanks for explaining though.


More information about the mesa-dev mailing list