[Mesa-dev] [PATCH] r600g: fix regression since UCMP change

Glenn Kennard glenn.kennard at gmail.com
Mon Dec 8 17:46:04 PST 2014


On Tue, 09 Dec 2014 02:31:01 +0100, Dave Airlie <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
> Since d8da6deceadf5e48201d848b7061dad17a5b7cac where the
> state tracker started using UCMP on cayman a number of tests
> regressed.
> this seems to be r600g is doing CNDGE_INT for UCMP which is >= 0,
> we should be doing CNDE_INT with reverse arguments.
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/drivers/r600/r600_shader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/src/gallium/drivers/r600/r600_shader.c  
> b/src/gallium/drivers/r600/r600_shader.c
> index 0b988df..28137e1 100644
> --- a/src/gallium/drivers/r600/r600_shader.c
> +++ b/src/gallium/drivers/r600/r600_shader.c
> @@ -6082,7 +6082,7 @@ static int tgsi_ucmp(struct r600_shader_ctx *ctx)
>  			continue;
> 		memset(&alu, 0, sizeof(struct r600_bytecode_alu));
> -		alu.op = ALU_OP3_CNDGE_INT;
> +		alu.op = ALU_OP3_CNDE_INT;
>  		r600_bytecode_src(&alu.src[0], &ctx->src[0], i);
>  		r600_bytecode_src(&alu.src[1], &ctx->src[2], i);
>  		r600_bytecode_src(&alu.src[2], &ctx->src[1], i);

Reviewed-by: Glenn Kennard <glenn.kennard at gmail.com>


More information about the mesa-dev mailing list