[Mesa-dev] [PATCH] r600g: only init GS_VERT_ITEMSIZE on r600

Glenn Kennard glenn.kennard at gmail.com
Tue Dec 9 20:22:45 PST 2014


On Wed, 10 Dec 2014 04:55:21 +0100, Dave Airlie <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
>
> On evergreen there are 4 regs, on r600/700 there is only one.
>
> Don't initialise regs and trash someone elses state.
>
> Not sure this fixes anything, but hey one less stupid.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/drivers/r600/r600_state.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/drivers/r600/r600_state.c  
> b/src/gallium/drivers/r600/r600_state.c
> index 61f5c5a..9a4b972 100644
> --- a/src/gallium/drivers/r600/r600_state.c
> +++ b/src/gallium/drivers/r600/r600_state.c
> @@ -2659,11 +2659,8 @@ void r600_update_gs_state(struct pipe_context  
> *ctx, struct r600_pipe_shader *sha
>  	r600_store_context_reg(cb, R_028A6C_VGT_GS_OUT_PRIM_TYPE,
>  			       r600_conv_prim_to_gs_out(rshader->gs_output_prim));
> -	r600_store_context_reg_seq(cb, R_0288C8_SQ_GS_VERT_ITEMSIZE, 4);
> -	r600_store_value(cb, cp_shader->ring_item_size >> 2);
> -	r600_store_value(cb, 0);
> -	r600_store_value(cb, 0);
> -	r600_store_value(cb, 0);
> +	r600_store_context_reg(cb, R_0288C8_SQ_GS_VERT_ITEMSIZE,
> +	                       cp_shader->ring_item_size >> 2);
> 	r600_store_context_reg(cb, R_0288A8_SQ_ESGS_RING_ITEMSIZE,
>  			       (rshader->ring_item_size) >> 2);

Reviewed-By: Glenn Kennard <glenn.kennard at gmail.com>


More information about the mesa-dev mailing list