[Mesa-dev] [PATCH 1/3] gallium: add TGSI_SEMANTIC_VERTEXID_ZEROBASE and TGSI_SEMANTIC_BASEVERTEX

[Ilia Mirkin]

On Thu, Dec 11, 2014 at 11:39 AM, Jose Fonseca <jfonseca at vmware.com> wrote:
> Overall I think this is a great cleanup.
>
> Just a remark about the chosen names.
>
> On 10/12/14 21:22, sroland at vmware.com wrote:
>>
>> From: Roland Scheidegger <sroland at vmware.com>
>
>
>
>
>> Plus a new PIPE_CAP_VERTEXID_NOOFFSET query.
>
>
> "Vertex offset" and "base vertex" are difference concepts, so I'd rather not
> mix them up.
>
> AFAICT, this is about base vertex, not offsets in vertex buffers, hence
> NOOFFSET seems to be a misnomer.  Please pick "NOBASE" or "ZEROBASE" suffix
> and stick with it.
>
> Personally, I prefer "NOBASE".  As "ZEROBASE" sounds like that base vertex
> must some how be zero, which is not the case.
>

Is all this really just about the base vertex? The situation on, e.g.,
a3xx is that the vertex id does not include any offset, even the
'start' from glDrawArrays (which makes sense, since they use the same
general logic).

  -ilia