[Mesa-dev] [RFC 6/8] mesa: remove support for GCC older than 4.1.0

[Jonathan Gray]

On Sat, Dec 13, 2014 at 09:09:27PM +1100, Timothy Arceri wrote:
> On Fri, 2014-12-12 at 07:01 -0600, kallisti5 wrote:
> > On 2014-12-12 05:46, Timothy Arceri wrote:
> > > Signed-off-by: Timothy Arceri <t_arceri at yahoo.com.au>
> > > ---
> > >  src/mesa/main/compiler.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
> > > index 34671dc..cdc843d 100644
> > > --- a/src/mesa/main/compiler.h
> > > +++ b/src/mesa/main/compiler.h
> > > @@ -122,7 +122,7 @@ extern "C" {
> > >   * inline a static function that we later use in an alias. - ajax
> > >   */
> > >  #ifndef PUBLIC
> > > -#  if (defined(__GNUC__) && __GNUC__ >= 4) || (defined(__SUNPRO_C) &&
> > > (__SUNPRO_C >= 0x590))
> > > +#  if defined(__GNUC__) || (defined(__SUNPRO_C) && (__SUNPRO_C >= 
> > > 0x590))
> > >  #    define PUBLIC __attribute__((visibility("default")))
> > >  #    define USED __attribute__((used))
> > >  #  else
> > 
> > Why not also drop the SUNPRO_C version check?
> > 
> > #  if defined(__GNUC__) || defined(__SUNPRO_C)
> > 
> > I downloaded SunStudio 12 (circa 2007) and __SUNPRO_C is set to 0x590.
> > If we drop support for GCC 4.1 (2007), might as well drop older sun 
> > compilers.
> 
> 
> The series is dropping support for GCC 4.0. 4.1 is shipped with Redhat
> Enterprise Linux 5 which is still in support so I've set that as the
> minimum version.

It is worth pointing out OpenBSD ships a patched GCC 4.2.1 as the base
compiler as that was the last GPLv2 licensed version.  Not relevant this
time, perhaps it will be next time.