[Mesa-dev] [PATCH 087/133] i965/fs_nir: Don't dump the shader.

[Jason Ekstrand]

On Tue, Dec 16, 2014 at 1:41 PM, Connor Abbott <cwabbott0 at gmail.com> wrote:
>
> Can we squash this into wherever we introduced these print statements,
> and instead port over Matt's i965 fs debugging infrastructure so we
> can do this with an envvar enable, plus all the other goodies?
>

No, there isn't a single patch I can squish this with.  Yes, I could unwind
shader printing from the series and just remove the places where we print
it.  No, I'd rather not (see also the note in the 000 about rebasing,
history, etc.  also, It's more work than just a squash).

RE: Matt's nifty macro.  Absolutely. I'm planning to do that, but it should
be easy enough to do as its own patch later.
--Jason


>
> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > This is killing piglit.  I'll leave the logging local
> > ---
> >  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> > index f4656bc..0cd8fca 100644
> > --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> > +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> > @@ -51,9 +51,6 @@ fs_visitor::emit_nir_code()
> >     nir_opt_global_to_local(nir);
> >     nir_validate_shader(nir);
> >
> > -   if (1)
> > -      nir_print_shader(nir, stderr);
> > -
> >     nir_convert_to_ssa(nir);
> >     nir_validate_shader(nir);
> >
> > @@ -71,11 +68,9 @@ fs_visitor::emit_nir_code()
> >        progress |= nir_opt_peephole_ffma(nir);
> >        nir_validate_shader(nir);
> >     } while (progress);
> > -   nir_print_shader(nir, stderr);
> >
> >     nir_convert_from_ssa(nir);
> >     nir_validate_shader(nir);
> > -   nir_print_shader(nir, stderr);
> >     nir_lower_vec_to_movs(nir);
> >     nir_validate_shader(nir);
> >
> > --
> > 2.2.0
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141216/0b3e6829/attachment.html>