[Mesa-dev] [PATCH 1/3] mesa: bump required GCC version to 4.2.0

Timothy Arceri t_arceri at yahoo.com.au
Wed Dec 17 13:54:51 PST 2014


On Thu, 2014-12-18 at 08:46 +1100, Timothy Arceri wrote:
> On Wed, 2014-12-17 at 13:15 -0800, Matt Turner wrote:
> > On Wed, Dec 17, 2014 at 12:51 PM, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
> > > It turns out Mesa hasn't compiled on less
> > > then 4.2 for a while so update conf to
> > > reflect this.
> > 
> > The first two are:
> > 
> > Reviewed-by: Matt Turner <mattst88 at gmail.com>
> > 
> > and the last is
> > 
> > Acked-by: Matt Turner <mattst88 at gmail.com>
> > 
> > By the way, you seem to be manually line wrapping your commit
> > messages. vim is apparently run with appropriate options here when I
> > git commit such that it automatically handles this. I haven't done
> > anything to configure this.
> 
> Yeah I started doing it after sending in a couple of patches with long
> commit messages that were on a single line (although admittedly now that
> I think about it I think I edited the message directly in a patch file
> in those cases).
> 
> I thought it was automatically wrapped too but last week I tried to edit
> a commit message during a rebase on one of the patches with the long
> commit message and it wouldn't automatically wrap it so I started
> doubting if it was wrapped when doing a commit also.
> Maybe a bug? But more likely just me not using git correctly.
> 
> Anyway I'll try remove the manual wrapping before committing.

I just tested a commit no automatic line wrapping on my system. I don't
believe I changed anything. Anyway I'll make the commit message a little
longer as brian suggested.

> 
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev




More information about the mesa-dev mailing list