[Mesa-dev] [PATCH 09/12] egl: Adding Haiku configs, not stable yet

[Emil Velikov]

On 22/12/14 14:36, Alexander von Gluck IV wrote:
> From: Adrián Arroyo Calle <adrian.arroyocalle at gmail.com>
> 
> ---
>  src/egl/drivers/dri2/egl_dri2.c         |    7 ++
>  src/egl/drivers/dri2/platform_haiku.cpp |  172 +++++++++++++++++++++++++------
>  src/egl/main/SConscript                 |   14 ++-
>  src/egl/main/egldisplay.c               |    4 +
>  4 files changed, 160 insertions(+), 37 deletions(-)
> 
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index 062fb54..5bda4fd 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -398,9 +398,16 @@ dri2_open_driver(_EGLDisplay *disp)
>  	       "%.*s/tls/%s_dri.so", len, p, dri2_dpy->driver_name);
>        dri2_dpy->driver = dlopen(path, RTLD_NOW | RTLD_GLOBAL);
>  #endif
> +
> +
>        if (dri2_dpy->driver == NULL) {
> +#ifndef HAVE_HAIKU_PLATFORM
>  	 snprintf(path, sizeof path,
>  		  "%.*s/%s_dri.so", len, p, dri2_dpy->driver_name);
> +#else
> +	 snprintf(path, sizeof path,
> +		  "lib%s.so",len,p,dri2_dpy->driver_name);
> +#endif
Imho Haiku's way of "reinventing" the DRI model/modules is rather
unfortunate, and it would be nice if it can just follow suite. Unless of
course there is some real (technical) reasons which prohibits it from
going otherwise.

With EGL support incoming, it would be nice to "start a fresh"

Thanks
Emil