[Mesa-dev] [PATCH 04/21] i965/fs: Disallow SIMD16 multiplies on GEN8

Ben Widawsky benjamin.widawsky at intel.com
Mon Dec 22 19:29:14 PST 2014


As far as we know, this isn't allowed on GEN8. Quoting the IVB PRM which talks
of the hazard for GEN7, "These features or behaviors are specific to IVB and may
not continue to later generations" We have no evidence to the contrary.

In a few patches, after enabling GEN7, we will minimize the impact on GEN8 as
well.

Cc: Kenneth Graunke <kenneth at whitecape.org>
Cc: Matt Turner <mattst88 at gmail.com>
Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
---
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index bd9345e..5b83c40 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
@@ -789,7 +789,7 @@ fs_visitor::visit(ir_expression *ir)
       }
       break;
    case ir_binop_imul_high: {
-      if (brw->gen == 7)
+      if (brw->gen >= 7)
          no16("SIMD16 explicit accumulator operands unsupported\n");
 
       struct brw_reg acc = retype(brw_acc_reg(dispatch_width),
-- 
2.2.1



More information about the mesa-dev mailing list